Lazily load the attachment_upload_to configuration setting
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring up to date with master
|
Thank you for contribution, @djw27. We can make it without breaking backward compatibilties by detecting the type of And it would be much appreciated if you can also provide a test for it. |
lqez
force-pushed
the
main
branch
2 times, most recently
from
1a3c1dc
to
a194f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project structure we can't simply import a function into our settings file to use within the
SUMMERNOTE_CONFIG- trying to import a function before the project has been initialised simply doesn't work. In our specific case we import settings from environment variables and use a multiple settings files per environment which complicates things further.This PR changes the
attachment_upload_toto accept the dot notation to the file to be used, which is then loaded when it's needed.This is a breaking change so I could work some backwards compatibility in to this if it's something you'd like to use in master?